On 03 April 2017 15:31, Lee Jones wrote:

Subject: Re: [PATCH V7 4/7] mfd: da9061: MFD core support

On Mon, 03 Apr 2017, Steve Twiss wrote:

quoted

On 03 April 2017 15:12, Lee Jones wrote:

quoted

quoted

@@ -475,7 +855,25 @@ static int da9062_i2c_probe(struct i2c_client *i2c,
 		return -EINVAL;
 	}

-	chip->regmap = devm_regmap_init_i2c(i2c, &da9062_regmap_config);
+	switch (chip->chip_type) {
+	case(COMPAT_TYPE_DA9061):

Brackets around the case value?

That's a new one on me.

Hm. Do you want me to resend it without braces?

Yes please.  And a space after the 'case'.

Hi Lee,

I have resent PATCH V7 to change "case(X):" to be "case X:".
- Removed brackets surrounding case statements for
    case COMPAT_TYPE_DA9061:
    case COMPAT_TYPE_DA9062:

New patch is here:
https://lkml.org/lkml/2017/4/3/462

The patch it is called by the same title "[PATCH V7 4/7] mfd: da9061: MFD core support".
I've not updated the whole patch-set or changed the patch version number from V7.

Regards,
Steve