Re: [PATCH] HID: cp2112: use proper hidraw name with minor number
From: Benjamin Tissoires <hidden>
Date: 2017-03-02 14:17:41
On Mar 02 2017 or thereabouts, Jaejoong Kim wrote:
The cp2112 driver is working on hidraw not hiddev. So we need to use proper hidraw name with hidraw's minor number. Signed-off-by: Jaejoong Kim <redacted> ---
Looks good to me: Reviewed-by: Benjamin Tissoires <redacted> However, this one should probably be sent in the series "[PATCH 0/2] HID: hiddev: move hiddev's minor number and refactoring" as it is a requirement for this series. I'd say resubmit this one in the v2 of the series (with my reviewed-by), so that the series is consistent and Jiri knows that this one needs to come before the rest of the series. Cheers, Benjamin
quoted hunk ↗ jump to hunk
drivers/hid/hid-cp2112.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)diff --git a/drivers/hid/hid-cp2112.c b/drivers/hid/hid-cp2112.c index b22d0f8..078026f 100644 --- a/drivers/hid/hid-cp2112.c +++ b/drivers/hid/hid-cp2112.c@@ -27,6 +27,7 @@ #include <linux/gpio.h> #include <linux/gpio/driver.h> #include <linux/hid.h> +#include <linux/hidraw.h> #include <linux/i2c.h> #include <linux/module.h> #include <linux/nls.h>@@ -1297,7 +1298,8 @@ static int cp2112_probe(struct hid_device *hdev, const struct hid_device_id *id) dev->adap.algo_data = dev; dev->adap.dev.parent = &hdev->dev; snprintf(dev->adap.name, sizeof(dev->adap.name), - "CP2112 SMBus Bridge on hiddev%d", hdev->minor); + "CP2112 SMBus Bridge on hidraw%d", + ((struct hidraw *)hdev->hidraw)->minor); dev->hwversion = buf[2]; init_waitqueue_head(&dev->wait);-- 2.7.4