Thread (6 messages) 6 messages, 2 authors, 2017-03-27

Re: [PATCH v2 3/3] Input: qt1070 - Add OF device ID table

flat view

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2017-03-23 21:46:08
Also in: lkml

On Thu, Mar 23, 2017 at 04:14:56PM -0300, Javier Martinez Canillas wrote:
Hello Dmitry,

On 02/22/2017 11:40 AM, Javier Martinez Canillas wrote:
quoted
The driver doesn't have a struct of_device_id table but supported devices
are registered via Device Trees. This is working on the assumption that a
I2C device registered via OF will always match a legacy I2C device ID and
that the MODALIAS reported will always be of the form i2c:<device>.

But this could change in the future so the correct approach is to have an
OF device ID table if the devices are registered via OF.

The compatible strings don't have a vendor prefix because that's how it's
used currently, and changing this will be a Device Tree ABI break.

Signed-off-by: Javier Martinez Canillas <redacted>
---
What's your decision about this patch series?
OK, I queued them for -next. Could you also make a patch to update
binding docs for silead?

Thanks!

-- 
Dmitry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help