Re: [PATCH 2/2] Fix the issue that V8 Button pad Stick button does not work
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2017-03-17 21:26:30
Also in:
lkml
On Tue, Mar 14, 2017 at 10:34:13AM +0900, Masaki Ota wrote:
From: Masaki Ota <redacted> - V8 Button pad Stick Right and Middle button don't work. - Alps stick devices have physical buttons absolutely, so delete "ALPS_BUTTONPAD" check Flag from Stick button process. Signed-off-by: Masaki Ota <redacted> Acked-by: Pali Rohar <redacted>
Reworded commit message, marked for stable and applied, thank you.
quoted hunk ↗ jump to hunk
--- drivers/input/mouse/alps.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)diff --git a/drivers/input/mouse/alps.c b/drivers/input/mouse/alps.c index 253f742..262d105 100644 --- a/drivers/input/mouse/alps.c +++ b/drivers/input/mouse/alps.c@@ -1287,10 +1287,8 @@ static int alps_decode_ss4_v2(struct alps_fields *f, /* handle buttons */ if (pkt_id == SS4_PACKET_ID_STICK) { f->ts_left = !!(SS4_BTN_V2(p) & 0x01); - if (!(priv->flags & ALPS_BUTTONPAD)) { - f->ts_right = !!(SS4_BTN_V2(p) & 0x02); - f->ts_middle = !!(SS4_BTN_V2(p) & 0x04); - } + f->ts_right = !!(SS4_BTN_V2(p) & 0x02); + f->ts_middle = !!(SS4_BTN_V2(p) & 0x04); } else { f->left = !!(SS4_BTN_V2(p) & 0x01); if (!(priv->flags & ALPS_BUTTONPAD)) {-- 2.9.3
-- Dmitry