Re: [PATCH] hid: hid-sensor-prox: Add more data field for hysteresis parsing
From: Jonathan Cameron <hidden>
Date: 2017-02-19 11:50:21
Also in:
linux-iio
Possibly related (same subject, not in this thread)
- 2017-02-13 · [PATCH] hid: hid-sensor-prox: Add more data field for hysteresis parsing · Song Hongyan <hidden>
On 13/02/17 09:54, Song Hongyan wrote:
Add HID_USAGE_SENSOR_HUMAN_PRESENCE support for Human Presence sensitivity parsing, in case some implementation uses it as sensitivity modifier. Signed-off-by: Song Hongyan <redacted>
Do we want to perhaps indicate to userspace in some way that this is what is being reported? (not that I have any idea how a proximity sensor could potentially tell a human from a passing cat for example ;) Otherwise, I'm fine with this but would like an Ack from Srinivas.
quoted hunk
--- drivers/iio/light/hid-sensor-prox.c | 7 +++++++ 1 file changed, 7 insertions(+)diff --git a/drivers/iio/light/hid-sensor-prox.c b/drivers/iio/light/hid-sensor-prox.c index 45ca056..73fced8 100644 --- a/drivers/iio/light/hid-sensor-prox.c +++ b/drivers/iio/light/hid-sensor-prox.c@@ -240,6 +240,13 @@ static int prox_parse_report(struct platform_device *pdev, st->common_attributes.sensitivity.index, st->common_attributes.sensitivity.report_id); } + if (st->common_attributes.sensitivity.index < 0) + sensor_hub_input_get_attribute_info(hsdev, + HID_FEATURE_REPORT, usage_id, + HID_USAGE_SENSOR_DATA_MOD_CHANGE_SENSITIVITY_ABS | + HID_USAGE_SENSOR_HUMAN_PRESENCE, + &st->common_attributes.sensitivity); + return ret; }