Thread (9 messages) 9 messages, 2 authors, 2017-02-23

Re: [PATCH 1/4] input:touchscreen:ad7879-spi.c: Fix regmap flag_masks

From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2017-02-23 08:43:59
Also in: lkml

On Wed, Feb 22, 2017 at 05:14:35PM +0100, michael.hennerich@analog.com wrote:
From: Michael Hennerich <michael.hennerich@analog.com>

Mask only applied to the top byte of the register

Signed-off-by: Michael Hennerich <michael.hennerich@analog.com>
Thank you Michael, I folded it with the patch introducing regmaps.
quoted hunk ↗ jump to hunk
---
 drivers/input/touchscreen/ad7879-spi.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/input/touchscreen/ad7879-spi.c b/drivers/input/touchscreen/ad7879-spi.c
index f2c06b5..b995891 100644
--- a/drivers/input/touchscreen/ad7879-spi.c
+++ b/drivers/input/touchscreen/ad7879-spi.c
@@ -19,8 +19,8 @@
 
 #define MAX_SPI_FREQ_HZ      5000000
 
-#define AD7879_CMD_MAGIC     0xE000
-#define AD7879_CMD_READ      BIT(10)
+#define AD7879_CMD_MAGIC     0xE0
+#define AD7879_CMD_READ      BIT(2)
 
 static const struct regmap_config ad7879_spi_regmap_config = {
 	.reg_bits = 16,
-- 
2.7.4
-- 
Dmitry
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help