Re: [PATCH v2 01/16] chardev: add helper function to register char devs with a struct device

On Mon, Feb 27, 2017 at 7:27 PM, Logan Gunthorpe [off-list ref] wrote:

On 27/02/17 09:56 AM, Jason Gunthorpe wrote:

quoted

Yes please, that is way too subtle. Suggest:

NOTE: Callers must assume that userspace was able to open the cdev and
can call cdev fops callbacks at any time, even if this function fails.

I would also add a note to cdev_device_del:

NOTE: This guarantees that associated sysfs callbacks are not running
or runnable, however any open cdevs will remain and their fops remain
callable even after this returns.

Since I have seen a lot of confusion on that point as well..

Sure, I'll add that verbiage to a v3 sometime after rc1.

It would also be great to patch1 into a stable non-rebasing git tree
so it can be used as a baseline for other 4.12 targeted development.
The device-dax patches in particular collide with some pending
development.

-- 
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
--- 
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org
For more options, visit https://groups.google.com/d/optout.