Re: [PATCH v2 02/16] device-dax: fix cdev leak
From: Dan Williams <hidden>
Date: 2017-02-26 18:22:36
Also in:
linux-fsdevel, linux-gpio, linux-rdma, linux-rtc, linux-scsi, nvdimm
Possibly related (same subject, not in this thread)
- 2017-02-26 · [PATCH v2 02/16] device-dax: fix cdev leak · Logan Gunthorpe <hidden>
On Sat, Feb 25, 2017 at 10:38 PM, Logan Gunthorpe [off-list ref] wrote:
From: Dan Williams <redacted>
If device_add() fails, cleanup the cdev. Otherwise, we leak a kobj_map()
with a stale device number.
As Jason points out, there is a small possibility that userspace has
opened and mapped the device in the time between cdev_add() and the
device_add() failure. We need a new kill_dax_dev() helper to invalidate
any established mappings.
Fixes: ba09c01d2fa8 ("dax: convert to the cdev api")
Cc: <redacted>
Cc: Logan Gunthorpe <logang-OTvnGxWRz7hWk0Htik3J/w@public.gmane.org>
Reported-by: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Signed-off-by: Dan Williams <redacted>Since you are forwarding this patch you should add "Signed-off-by: Logan Gunthorpe [off-list ref]"