Re: [PATCH 02/14] device-dax: utilize new device_add_cdev helper function
From: Dan Williams <hidden>
Date: 2017-02-21 19:26:33
Also in:
linux-fsdevel, linux-gpio, linux-rdma, linux-rtc, linux-scsi, nvdimm
Possibly related (same subject, not in this thread)
- 2017-02-21 · Re: [PATCH 02/14] device-dax: utilize new device_add_cdev helper function · Alexandre Belloni <hidden>
- 2017-02-21 · [PATCH 02/14] device-dax: utilize new device_add_cdev helper function · Logan Gunthorpe <hidden>
On Tue, Feb 21, 2017 at 3:37 AM, Alexandre Belloni [off-list ref] wrote:
Hi, A small comment, you must always have a commit message. Even if it is small.
Yes, something like: "Replace the open coded initialization of the cdev with the new device_add_cdev() helper. The helper takes the proper reference against the parent device while the cdev object is alive." With that you can also add: Acked-by: Dan Williams <redacted> -- You received this message because you are subscribed to "rtc-linux". Membership options at http://groups.google.com/group/rtc-linux . Please read http://groups.google.com/group/rtc-linux/web/checklist before submitting a driver. --- You received this message because you are subscribed to the Google Groups "rtc-linux" group. To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe-/JYPxA39Uh5TLH3MbocFF+G/Ez6ZCGd0@public.gmane.org For more options, visit https://groups.google.com/d/optout.