[PATCH v2] hid-lg: Fix immediate disconnection of Logitech Rumblepad 2

Subsystems: hid core layer, the rest

STALE3476d

3 messages, 3 authors, 2017-01-26 · open the first message on its own page

[PATCH v2] hid-lg: Fix immediate disconnection of Logitech Rumblepad 2

From: Ardinartsev Nikita <hidden>
Date: 2017-01-26 13:54:46

hid-lg: Fix immediate disconnection of Logitech Rumblepad 2

With NOGET quirk Logitech F510 is now fully workable in dinput mode 
including rumble effects (according to fftest).
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=117091
Signed-off-by: Ardinartsev Nikita <redacted>
---
  drivers/hid/hid-lg.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-lg.c b/drivers/hid/hid-lg.c
index c5c5fbe..52026dc 100644
--- a/drivers/hid/hid-lg.c
+++ b/drivers/hid/hid-lg.c
@@ -872,7 +872,7 @@ static const struct hid_device_id lg_devices[] = {
  	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 
USB_DEVICE_ID_LOGITECH_WINGMAN_FFG),
  		.driver_data = LG_NOGET | LG_FF4 },
  	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 
USB_DEVICE_ID_LOGITECH_RUMBLEPAD2),
-		.driver_data = LG_FF2 },
+		.driver_data = LG_NOGET | LG_FF2 },
  	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, 
USB_DEVICE_ID_LOGITECH_FLIGHT_SYSTEM_G940),
  		.driver_data = LG_FF3 },
  	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_SPACENAVIGATOR),
-- 
2.7.4

Re: [PATCH v2] hid-lg: Fix immediate disconnection of Logitech Rumblepad 2

From: Benjamin Tissoires <hidden>
Date: 2017-01-26 14:17:25

On Jan 26 2017 or thereabouts, Ardinartsev Nikita wrote:
hid-lg: Fix immediate disconnection of Logitech Rumblepad 2

With NOGET quirk Logitech F510 is now fully workable in dinput mode
including rumble effects (according to fftest).
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=117091
Signed-off-by: Ardinartsev Nikita <redacted>
---
Acked-by: Benjamin Tissoires <redacted>
quoted hunk
 drivers/hid/hid-lg.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-lg.c b/drivers/hid/hid-lg.c
index c5c5fbe..52026dc 100644
--- a/drivers/hid/hid-lg.c
+++ b/drivers/hid/hid-lg.c
@@ -872,7 +872,7 @@ static const struct hid_device_id lg_devices[] = {
 	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
USB_DEVICE_ID_LOGITECH_WINGMAN_FFG),
 		.driver_data = LG_NOGET | LG_FF4 },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
USB_DEVICE_ID_LOGITECH_RUMBLEPAD2),
-		.driver_data = LG_FF2 },
+		.driver_data = LG_NOGET | LG_FF2 },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH,
USB_DEVICE_ID_LOGITECH_FLIGHT_SYSTEM_G940),
 		.driver_data = LG_FF3 },
 	{ HID_USB_DEVICE(USB_VENDOR_ID_LOGITECH, USB_DEVICE_ID_SPACENAVIGATOR),
-- 
2.7.4

Re: [PATCH v2] hid-lg: Fix immediate disconnection of Logitech Rumblepad 2

From: Jiri Kosina <jikos@kernel.org>
Date: 2017-01-26 20:59:40

On Thu, 26 Jan 2017, Ardinartsev Nikita wrote:
hid-lg: Fix immediate disconnection of Logitech Rumblepad 2

With NOGET quirk Logitech F510 is now fully workable in dinput mode including
rumble effects (according to fftest).
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=117091
Signed-off-by: Ardinartsev Nikita <redacted>
The patch has been line-wrapped by your mail clinet. Please fix that up 
for any future submissions.

I've now fixed it up manually on my side and applied, thanks.

-- 
Jiri Kosina
SUSE Labs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help