Re: [PATCH] Input: ALPS - fix TrackStick Y axis handling for SS5 hardware
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2017-01-03 19:14:30
On Tue, Jan 03, 2017 at 07:45:29AM -0500, Paul Donohue wrote:
A minus character was lost in commit 23fce365, causing the Y axis to be inverted for SS5 TrackStick events. (Pushing the TrackStick up caused the pointer to move down, and vice versa.) Restore the lost minus. Signed-off-by: Paul Donohue <redacted>
Applied, thank you.
quoted hunk ↗ jump to hunk
--- drivers/input/mouse/alps.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/input/mouse/alps.h b/drivers/input/mouse/alps.h index cde6f4b..6d279aa 100644 --- a/drivers/input/mouse/alps.h +++ b/drivers/input/mouse/alps.h@@ -114,7 +114,7 @@ enum SS4_PACKET_ID { (_b[1] & 0x7F) \ ) -#define SS4_TS_Y_V2(_b) (s8)( \ +#define SS4_TS_Y_V2(_b) -(s8)( \ ((_b[3] & 0x01) << 7) | \ (_b[2] & 0x7F) \ )-- 2.9.3
-- Dmitry