Re: [PATCH 13/33] Input: bfin_rotary - Use 'dev' instead of dereferencing it and other changes
From: Guenter Roeck <linux@roeck-us.net>
Date: 2017-01-19 08:26:15
Also in:
lkml
On 01/18/2017 08:58 PM, Joe Perches wrote:
On Wed, 2017-01-18 at 12:35 -0800, Guenter Roeck wrote:quoted
On Wed, Jan 18, 2017 at 11:39:52AM -0800, Dmitry Torokhov wrote:quoted
On Wed, Jan 18, 2017 at 09:46:34AM -0800, Guenter Roeck wrote:[]quoted
quoted
quoted
diff --git a/drivers/input/misc/bfin_rotary.c b/drivers/input/misc/bfin_rotary.c[]quoted
quoted
quoted
@@ -141,25 +141,23 @@ static int bfin_rotary_probe(struct platform_device *pdev) /* Basic validation */ if ((pdata->rotary_up_key && !pdata->rotary_down_key) || - (!pdata->rotary_up_key && pdata->rotary_down_key)) { + (!pdata->rotary_up_key && pdata->rotary_down_key))maybe just use ^ if (!pdata->rotary_up_key ^ !pdata->rotary_down_key)
Interesting use case for a coccinelle rule. To address the coccinelle related problem, I modified the rule to only apply if the expression is in one line, and if the return statement is in the next line. That works pretty well. Guenter