Thread (16 messages) 16 messages, 5 authors, 2017-01-15

Re: [PATCH] Input: synaptics-rmi4 - make F03 a tristate symbol

From: Arnd Bergmann <arnd@arndb.de>
Date: 2017-01-14 12:17:12
Also in: lkml

On Jan 13, 2017 10:42 PM, "Dmitry Torokhov" [off-list ref] wrote:
On Fri, Jan 13, 2017 at 10:34:32PM +0100, Arnd Bergmann wrote:
quoted
config RMI4_F03_SERIO
       tristate
       depends on RMI4_CORE
       depends on RMI4_F03
       default RMI4_CORE
       select SERIO

As that avoids the 'depends on SERIO=y || RMI4_CORE=SERIO' statement that
is different from the other SERIO users, it keeps it all in one place,
and it doesn't
prevent you from seeing the RMI4_F03 symbol when SERIO=m.
Hmm, if this works and resilient with user changing symbols after
they've been auto-selected then I like it. How can we run it through
multitude of randconfigs?
I've successfully run it over night on a few hundred randconfig builds without
problems now, so I'm pretty confident it works.

The hidden option will ensure the configuration is always valid even when
the user changes it, the only thing that can be unexpected is the same as
every 'select': when you enable this option, SERIO will get turned on, and
when you disable it again after leaving 'menuconfig', it stays on.

    Arnd
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help