Re: [PATCH] Input: egalax_ts - do not release gpio if probe successful

Hi Dmitri,

On Thu, Jan 12, 2017 at 10:30:19AM -0800, Dmitry Torokhov wrote:

Hi Gary,

On Wed, Jan 11, 2017 at 06:28:41PM +0100, Gary Bisson wrote:

quoted

Thus preventing anyone to later modify the interrupt GPIO direction
and/or state without the driver knowing.

I am afraid not releasing gpio after waking up the controller will cause
request_irq to fail if we are using the same pin for interrupt and
wakeup (as majority of current DTSes do: see
arch/arm/boot/dts/imx53-tx53-x13x.dts for example).

No, keeping the GPIO doesn't prevent from requesting the IRQ.

However it keeps other drivers/users from changing the GPIO as output
later on.

You'll need to figure out if irq is backed by the same gpio as wakeup
and act accordingly.

What setup did you test this on? Was it shared pin or dedicated wakeup?

I've tested on i.MX6Q Nitrogen6x [1] with Hannstar 10" display [2].

Regards,
Gary

[1] https://boundarydevices.com/product/nitrogen6x-board-imx6-arm-cortex-a9-sbc/
[2] https://boundarydevices.com/product/nit6x_10-1hannstar/