Thread (4 messages) 4 messages, 3 authors, 2016-11-15

RE: [PATCH 3/3] hid: intel-ish-hid: ipc: use msleep_interrupt() for wait

flat view

From: "Xu, Even" <even.xu@intel.com>
Date: 2016-11-15 14:37:20

Hi, Jiri,

This issue was found by code inspection, no real bug was reported.
Thanks!

Best Regards,
Even Xu

-----Original Message-----
From: Jiri Kosina [mailto:jikos@kernel.org] 
Sent: Tuesday, November 15, 2016 9:27 PM
To: Xu, Even <even.xu@intel.com>
Cc: linux-input@vger.kernel.org; Pandruvada, Srinivas <redacted>
Subject: Re: [PATCH 3/3] hid: intel-ish-hid: ipc: use msleep_interrupt() for wait

On Fri, 11 Nov 2016, Even Xu wrote:
set_current_task() must be called before schedule_timeout(), for this 
driver, in order to avoid incorrect usage, use msleep_interrupt() 
instead.

Signed-off-by: Even Xu <even.xu@intel.com>
Is this fixing a bug that has been observed / reported in a real life, or has this been found purely via code inspection? (asking to schedule upstream merge properly).

Thanks,

--
Jiri Kosina
SUSE Labs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help