RE: [PATCH] Input: mt: only perform pointer emulation on drivers desiring this functionality
From: Bird, Timothy <hidden>
Date: 2016-10-28 00:08:54
-----Original Message----- From: Roderick Colenbrander on Thursday, October 27, 2016 2:31 PM
The input-mt driver pointer emulation from 'input_mt_sync_frame' regardless of the flags passed in to 'input_mt_init_slots' by device drivers.
There seems to be a verb missing from this sentence.
quoted hunk ↗ jump to hunk
Pointer emulation is undesired on drivers, which didn't request this capability like the hid-sony driver for the Dualshock 4. This gamepad already reports ABS_X / ABS_Y for gamepad stick purposes. Pointer emulation would inject touchpad values into these sticks, which is undesired. This patch checks the flags INPUT_MT_POINTER / INPUT_MT_DIRECT from within input_mt_sync_frame to only allow pointer emulation when the feature was requested by the driver as the flags were set in input_mt_init_slots. --- drivers/input/input-mt.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)diff --git a/drivers/input/input-mt.c b/drivers/input/input-mt.c index a1bbec9..30c8128 100644 --- a/drivers/input/input-mt.c +++ b/drivers/input/input-mt.c@@ -305,7 +305,8 @@ void input_mt_sync_frame(struct input_dev *dev) if ((mt->flags & INPUT_MT_POINTER) && !(mt->flags &INPUT_MT_SEMI_MT)) use_count = true; - input_mt_report_pointer_emulation(dev, use_count); + if (mt->flags & (INPUT_MT_POINTER | INPUT_MT_DIRECT)) + input_mt_report_pointer_emulation(dev, use_count); mt->frame++; } -- 2.7.4