Thread (2 messages) 2 messages, 2 authors, 2016-10-19

Re: [PATCH 3/4] hid: intel-ish-hid: ipc: Fix driver reinit failure

flat view

From: Pandruvada, Srinivas <hidden>
Date: 2016-10-19 14:10:37

On Wed, 2016-10-19 at 09:58 +0000, Ooi, Joyce wrote:

[...]
quoted
+	/* Put ISH to D3 state for power saving */
+	pci_read_config_word(pdev, pdev->pm_cap + PCI_PM_CTRL,
&csr);
+
+	csr &= ~PCI_PM_CTRL_STATE_MASK;
+	csr |= PCI_D3hot;
+	pci_write_config_word(pdev, pdev->pm_cap + PCI_PM_CTRL,
csr);
+
Do you think it would be cleaner if we use pci_set_power_state() ?
http://lxr.free-electrons.com/source/drivers/pci/pci.c#L877
Makes sense.
I will test and update this.

Thanks,
Srinivas
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help