Re: [PATCH] Input: psmouse - cleanup Focaltech code
From: Mathias Gottschlag <hidden>
Date: 2016-10-17 17:28:11
Also in:
lkml
The changes look good to me. However, what wording do other drivers use? I've seen "TouchPad" with a capital P before. If this patch breaks scripts searching for that string anyways, that's an opportunity to unify the capitalization there. It probably doesn't matter, though... I don't see a problem with this patch. I can't test it because I no longer have the hardware. Am 08.10.2016 um 12:38 schrieb Dmitry Tunin:
quoted hunk ↗ jump to hunk
psmouse->name "Focaltech Touchpad" is an overkill. In xinput it is too long as "FocaltechPS/2 Focaltech Focaltech Touchpad" In focaltech_report_state() pointer to psmouse->dev is already stored as *dev Signed-off-by: Dmitry Tunin <redacted> --- drivers/input/mouse/focaltech.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)diff --git a/drivers/input/mouse/focaltech.c b/drivers/input/mouse/focaltech.c index c8c6a8c..49a56f655 100644 --- a/drivers/input/mouse/focaltech.c +++ b/drivers/input/mouse/focaltech.c@@ -43,7 +43,7 @@ int focaltech_detect(struct psmouse *psmouse, bool set_properties) if (set_properties) { psmouse->vendor = "FocalTech"; - psmouse->name = "FocalTech Touchpad"; + psmouse->name = "Touchpad"; } return 0;@@ -146,8 +146,8 @@ static void focaltech_report_state(struct psmouse *psmouse) } input_mt_report_pointer_emulation(dev, true); - input_report_key(psmouse->dev, BTN_LEFT, state->pressed); - input_sync(psmouse->dev); + input_report_key(dev, BTN_LEFT, state->pressed); + input_sync(dev); } static void focaltech_process_touch_packet(struct psmouse *psmouse,