Re: Goodix touchscreen works intermittently, fails reading config info.

Irina,
  The user just reported... "the TS is not working every time, here is
a log from when it is not working". The below logging appears to show
that setting the default trigger_type=0 when read_config fails does
not make a difference.  His statement that it's not working *every
time* is curious because he said before it was working like 9 out of
10 times he booted up.

http://pastebin.com/hpWbgpTe
[   10.922484] Goodix-TS i2c-GDIX1001:00: ID 9111, version: 1060
[   10.927791] Goodix-TS i2c-GDIX1001:00: dev_info: cfg_len: 186,
x_max: 0, y_max: 0, touch_num: 0, trigger_type: 0
[   10.927797] Goodix-TS i2c-GDIX1001:00: Invalid config, using defaults
[   10.927912] Goodix-TS i2c-GDIX1001:00: dev_info: cfg_len: 186,
x_max: 2160, y_max: 2160, touch_num: 10, trigger_type: 0
[   10.928112] input: Goodix Capacitive TouchScreen as
/devices/pci0000:00/808622C1:05/i2c-13/i2c-GDIX1001:00/input/input6

source: https://github.com/blocksonic/gt9xx/blob/device-tree/goodix.c

I'm waiting for him to send the ACPI table data you requested.  I was
not sure exactly how to do this. I asked him to run this series of
commands which worked on my machine.  Is it OK?

mkdir ~/acpitables
cd /sys/firmware/acpi/tables/
for i in * ; do sudo cat $i > ~/acpitables/$i.dat; done
cd ~/acpitables
for i in * ; do iasl -d $i ; done
cat *.dsl >> chuwi_hi12_acpi.dsl

Also: following is an older log prior to my code changes where
read_config was succeeding but the user reported the touchscreen was
registering touch events in the wrong place.  This may have been some
fluke as he has not been reporting this type of problem happening
often or since.  Also appended to the end of this log is output from
dmidecode if it's  helpful:  http://pastebin.com/6QWF6JB8


On Sun, Sep 11, 2016 at 4:28 PM, Brad Baker [off-list ref] wrote:

Hi Irina,
  I don't have the tablet. The user's last reply yesterday was this:
"here is a log of the, TS working with your latest edits
http://pastebin.com/mhMpa3Zj . it might be a couple days before i can
do much more testing on it.  "
So I'm still waiting to find out if my changing the default
trigger_type=0 had any effect when read_config fails.
That log of the working case shows things as expected.

[   12.356637] goodix_backport: loading out-of-tree module taints kernel.
[   12.356739] goodix_backport: module verification failed: signature
and/or required key missing - tainting kernel
[   12.364644] intel_sst_acpi 808622A8:00: No matching machine driver found
[   12.365892] Goodix-TS i2c-GDIX1001:00: ID 9111, version: 1060
[   12.373813] Goodix-TS i2c-GDIX1001:00: dev_info: cfg_len: 186,
x_max: 2160, y_max: 2160, touch_num: 10, trigger_type: 0
[   12.373822] Goodix-TS i2c-GDIX1001:00: dev_info: cfg_len: 186,
x_max: 2160, y_max: 2160, touch_num: 10, trigger_type: 0
[   12.373998] input: Goodix Capacitive TouchScreen as
/devices/pci0000:00/808622C1:05/i2c-13/i2c-GDIX1001:00/input/input6



On Sun, Sep 11, 2016 at 3:54 PM, Tirdea, Irina [off-list ref] wrote:

quoted

quoted

-----Original Message-----
From: linux-input-owner@vger.kernel.org [mailto:linux-input-owner@vger.kernel.org] On Behalf Of Brad Baker
Sent: 11 September, 2016 0:21
To: bastien nocera
Cc: linux-input@vger.kernel.org
Subject: Goodix touchscreen works intermittently, fails reading config info.

Summary: Goodix touchscreen works intermittently, fails reading config info.
 https://bugzilla.kernel.org/show_bug.cgi?id=156511

Description:  Chuwi Hi12 tablet with Intel cherry-trail Atom Z8300,
the touchscreen does work after bootup most of the time, but sometimes
it does not work without running modprobe.  When it fails the dmesg
log shows the error "Invalid config, using defaults" and when it works
this error is not present.

Module: goodix, goodix_backport
Linux version 4.8.0-040800rc5-generic (kernel@tangerine) (gcc version
6.2.0 20160830 (Ubuntu 6.2.0-2ubuntu11) ) #201609041832 SMP Sun Sep 4
22:34:01 UTC 2016

dmesg log when it's failing:
[ 10.012314] Goodix-TS i2c-GDIX1001:00: ID 9111, version: 1060
[ 10.017711] Goodix-TS i2c-GDIX1001:00: Invalid config, using defaults
[ 10.018021] input: Goodix Capacitive TouchScreen as
/devices/pci0000:00/808622C1:05/i2c-13/i2c-GDIX1001:00/input/input6

details given in bugzilla #156511

Hi Brad,

I had similar problems with some Goodix devices until I enabled the
reset sequence [1].

Although the touch screen was initialized and I could read/write to/from
the device, I read only 0s from the configuration registers. The datasheet
recommends using the reset procedure at power on, so I could not find any
information on how to make the device work reliably without it. Resetting the
device at boot fixed the problem for me. For backwards compatibility, the
reset sequence is only available if the interrupt and reset gpio pins are
connected and configured through _DSD properties in the ACPI table or DT
properties.

One reason for the touchscreen not working in this case is that the interrupts
are not properly configured. I noticed in the Bugzilla details that you already
tried changing the default value for trigger_type to the one read from the device.
Did that work?

Regards,
Irina

[1] https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=ec6e1b4082d9f5b0858ce33169a1c22a27a982f6