Re: [PATCH 3/4] Input: elan_i2c - add Host Notify support
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2016-09-30 23:58:06
Also in:
lkml
On Wed, Sep 28, 2016 at 04:34:03PM +0200, Benjamin Tissoires wrote:
quoted hunk ↗ jump to hunk
The Thinkpad series 13 uses Host Notify to report the interrupt. Add elan_smb_alert() to handle those interrupts and disable the irq handling on this case. Signed-off-by: Benjamin Tissoires <redacted> --- drivers/input/mouse/elan_i2c_core.c | 100 ++++++++++++++++++++++++++++-------- 1 file changed, 78 insertions(+), 22 deletions(-)diff --git a/drivers/input/mouse/elan_i2c_core.c b/drivers/input/mouse/elan_i2c_core.c index 2de1f75..11671c7 100644 --- a/drivers/input/mouse/elan_i2c_core.c +++ b/drivers/input/mouse/elan_i2c_core.c@@ -96,6 +96,34 @@ struct elan_tp_data { bool baseline_ready; }; +static inline void elan_enable_irq(struct elan_tp_data *tp) +{ + if (tp->client->irq) + enable_irq(tp->client->irq);
Hmm, so I wonder, why alert is not implemented as irqchip? Then clients would not need to be bothered with these details, they'd simply requster and manipulate irqs. Thanks. -- Dmitry