Thread (11 messages) 11 messages, 3 authors, 2016-09-29

Re: [PATCH v6 1/4] mfd: mxs-lradc: Add support for mxs-lradc MFD

From: Stefan Wahren <hidden>
Date: 2016-09-29 01:39:03
Also in: linux-iio, lkml

Hi Lee,
Lee Jones [off-list ref] hat am 28. September 2016 um 03:05
geschrieben:


On Sat, 17 Sep 2016, Ksenija Stanojevic wrote:
quoted
+
+static int mxs_lradc_probe(struct platform_device *pdev)
+{
+	const struct of_device_id *of_id;
+	struct device *dev = &pdev->dev;
+	struct device_node *node = dev->of_node;
+	struct mxs_lradc *lradc;
+	struct mfd_cell *cells = NULL;
+	int ret = 0;
+	u32 ts_wires = 0;
+
+	lradc = devm_kzalloc(&pdev->dev, sizeof(*lradc), GFP_KERNEL);
+	if (!lradc)
+		return -ENOMEM;
+
+	of_id = of_match_device(mxs_lradc_dt_ids, &pdev->dev);
+	lradc->soc = (enum mxs_lradc_id)of_id->data;
+
+	lradc->clk = devm_clk_get(&pdev->dev, NULL);
+	if (IS_ERR(lradc->clk)) {
+		dev_err(dev, "Failed to get the delay unit clock\n");
+		return PTR_ERR(lradc->clk);
+	}
+
+	ret = clk_prepare_enable(lradc->clk);
+	if (ret) {
+		dev_err(dev, "Failed to enable the delay unit clock\n");
+		return ret;
+	}
+
+	ret = of_property_read_u32(node, "fsl,lradc-touchscreen-wires",
Have you moved the documentation into devicetree/bindings/mfd?
i hope it's okay if i answer. The binding has moved to
devicetree/binding/iio/adc/ [1]

Should it move completely to mfd or split too?

I'm asking myself how we keep DT ABI in the latter case.

[1] -
http://lxr.free-electrons.com/source/Documentation/devicetree/bindings/iio/adc/mxs-lradc.txt
-- 
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help