Re: [PATCH] HID: alps: fix stick device not working after resume
flat view
From: Jiri Kosina <jikos@kernel.org>
Date: 2016-09-19 12:37:13
Also in:
lkml
On Mon, 19 Sep 2016, Kai-Heng Feng wrote:
The stick device does not work after resume, add U1_SP_ABS_MODE flag can make the device work after resume.
Do you happen to have any more details on why it doesn't work without U1_SP_ABS_MODE? Or was this a pure guesswork?
quoted hunk ↗ jump to hunk
Signed-off-by: Kai-Heng Feng <redacted> --- drivers/hid/hid-alps.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)diff --git a/drivers/hid/hid-alps.c b/drivers/hid/hid-alps.c index 048befd..390f8d3 100644 --- a/drivers/hid/hid-alps.c +++ b/drivers/hid/hid-alps.c@@ -244,13 +244,13 @@ static int alps_raw_event(struct hid_device *hdev, static int alps_post_reset(struct hid_device *hdev) { return u1_read_write_register(hdev, ADDRESS_U1_DEV_CTRL_1, - NULL, U1_TP_ABS_MODE, false); + NULL, U1_TP_ABS_MODE | U1_SP_ABS_MODE, false); } static int alps_post_resume(struct hid_device *hdev) { return u1_read_write_register(hdev, ADDRESS_U1_DEV_CTRL_1, - NULL, U1_TP_ABS_MODE, false); + NULL, U1_TP_ABS_MODE | U1_SP_ABS_MODE, false); } #endif /* CONFIG_PM */
-- Jiri Kosina SUSE Labs