Re: [PATCH 1/2] dt-bindings: add the regulator optional properties
flat view
From: Rob Herring <robh@kernel.org>
Date: 2016-09-12 16:17:00
Also in:
linux-devicetree, linux-rockchip, lkml
On Mon, Sep 05, 2016 at 06:11:55AM +0800, Caesar Wang wrote:
Add the regulator properties that will be used to power on/off the regulator. Signed-off-by: Caesar Wang <redacted> Cc: Rob Herring <robh+dt@kernel.org> Cc: Jiri Kosina <jikos@kernel.org> Cc: linux-input@vger.kernel.org --- Documentation/devicetree/bindings/input/hid-over-i2c.txt | 3 +++ 1 file changed, 3 insertions(+)
I find this binding a bit questionable. The compatible should describe the actual device, not just the protocol it uses.
quoted hunk ↗ jump to hunk
diff --git a/Documentation/devicetree/bindings/input/hid-over-i2c.txt b/Documentation/devicetree/bindings/input/hid-over-i2c.txt index 488edcb..e648e44 100644 --- a/Documentation/devicetree/bindings/input/hid-over-i2c.txt +++ b/Documentation/devicetree/bindings/input/hid-over-i2c.txt@@ -17,6 +17,9 @@ Required properties: - interrupt-parent: the phandle for the interrupt controller - interrupts: interrupt line +Optional properties: +- power-supply: phandle of the regulator that provides the supply voltage.
This needs to be actual supplies for devices. What if a device has 2 supplies? Add a device compatible string and make this property specific to that device, then it's fine. Rob