[PATCH -next] HID: intel_ish-hid: Use kzalloc instead of kmalloc/memset

Subsystems: hid core layer, intel integrated sensor hub driver, the rest

STALE3633d

2 messages, 2 authors, 2016-08-26 · open the first message on its own page

[PATCH -next] HID: intel_ish-hid: Use kzalloc instead of kmalloc/memset

From: Wei Yongjun <hidden>
Date: 2016-08-21 15:31:17

Use kzalloc rather than kmalloc followed by memset with 0.

Generated by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci

Signed-off-by: Wei Yongjun <redacted>
---
 drivers/hid/intel-ish-hid/ishtp/client-buffers.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/hid/intel-ish-hid/ishtp/client-buffers.c b/drivers/hid/intel-ish-hid/ishtp/client-buffers.c
index 3f5ce5e..b9b917d 100644
--- a/drivers/hid/intel-ish-hid/ishtp/client-buffers.c
+++ b/drivers/hid/intel-ish-hid/ishtp/client-buffers.c
@@ -73,11 +73,10 @@ int ishtp_cl_alloc_tx_ring(struct ishtp_cl *cl)
 	for (j = 0; j < cl->tx_ring_size; ++j) {
 		struct ishtp_cl_tx_ring	*tx_buf;
 
-		tx_buf = kmalloc(sizeof(struct ishtp_cl_tx_ring), GFP_KERNEL);
+		tx_buf = kzalloc(sizeof(struct ishtp_cl_tx_ring), GFP_KERNEL);
 		if (!tx_buf)
 			goto	out;
 
-		memset(tx_buf, 0, sizeof(struct ishtp_cl_tx_ring));
 		tx_buf->send_buf.data = kmalloc(len, GFP_KERNEL);
 		if (!tx_buf->send_buf.data) {
 			kfree(tx_buf);


Re: [PATCH -next] HID: intel_ish-hid: Use kzalloc instead of kmalloc/memset

From: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
Date: 2016-08-26 19:05:34

On Sun, 2016-08-21 at 15:30 +0000, Wei Yongjun wrote:
Use kzalloc rather than kmalloc followed by memset with 0.

Generated by: scripts/coccinelle/api/alloc/kzalloc-simple.cocci

Signed-off-by: Wei Yongjun <redacted>
Acked-by: Srinivas Pandruvada <srinivas.pandruvada@linux.intel.com>
quoted hunk
---
 drivers/hid/intel-ish-hid/ishtp/client-buffers.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/hid/intel-ish-hid/ishtp/client-buffers.c
b/drivers/hid/intel-ish-hid/ishtp/client-buffers.c
index 3f5ce5e..b9b917d 100644
--- a/drivers/hid/intel-ish-hid/ishtp/client-buffers.c
+++ b/drivers/hid/intel-ish-hid/ishtp/client-buffers.c
@@ -73,11 +73,10 @@ int ishtp_cl_alloc_tx_ring(struct ishtp_cl *cl)
 	for (j = 0; j < cl->tx_ring_size; ++j) {
 		struct ishtp_cl_tx_ring	*tx_buf;
 
-		tx_buf = kmalloc(sizeof(struct ishtp_cl_tx_ring),
GFP_KERNEL);
+		tx_buf = kzalloc(sizeof(struct ishtp_cl_tx_ring),
GFP_KERNEL);
 		if (!tx_buf)
 			goto	out;
 
-		memset(tx_buf, 0, sizeof(struct ishtp_cl_tx_ring));
 		tx_buf->send_buf.data = kmalloc(len, GFP_KERNEL);
 		if (!tx_buf->send_buf.data) {
 			kfree(tx_buf);

Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help