Thread (2 messages) flat view 2 messages, 2 authors, 2016-08-04
STALE3657d

[patch] Input: silead - remove some dead code

From: Dan Carpenter <hidden>
Date: 2016-08-04 05:28:59
Also in: kernel-janitors
Subsystem: input (keyboard, mouse, joystick, touchscreen) drivers, silead touchscreen driver, the rest · Maintainers: Dmitry Torokhov, Hans de Goede, Linus Torvalds

buf[0] is an unsigned char.  touch_nr is an int.  The test for negative
here doesn't make sense so I have removed it.

Signed-off-by: Dan Carpenter <redacted>
diff --git a/drivers/input/touchscreen/silead.c b/drivers/input/touchscreen/silead.c
index 5f55167..7379fe1 100644
--- a/drivers/input/touchscreen/silead.c
+++ b/drivers/input/touchscreen/silead.c
@@ -147,9 +147,6 @@ static void silead_ts_read_data(struct i2c_client *client)
 	}
 
 	touch_nr = buf[0];
-	if (touch_nr < 0)
-		return;
-
 	if (touch_nr > data->max_fingers) {
 		dev_warn(dev, "More touches reported then supported %d > %d\n",
 			 touch_nr, data->max_fingers);
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help