Re: [PATCH] Input: tegra-kbc: fix inverted reset logic

From
Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date
2016-08-22 21:20:40
Also in
linux-tegra, lkml
Reply to
Masahiro Yamada, 2016-08-16
On Tue, Aug 16, 2016 at 11:59:23AM +0900, Masahiro Yamada wrote:
Commit fe6b0dfaba68 ("Input: tegra-kbc - use reset framework")
accidentally converted _deassert to _assert, so there is no code
to wake up this hardware.

Fixes: fe6b0dfaba68 ("Input: tegra-kbc - use reset framework")
Signed-off-by: Masahiro Yamada <redacted>
Applied, thank you.
quoted hunk ↗ jump to hunk
---

 drivers/input/keyboard/tegra-kbc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/keyboard/tegra-kbc.c b/drivers/input/keyboard/tegra-kbc.c
index 7d61439..0c07e10 100644
--- a/drivers/input/keyboard/tegra-kbc.c
+++ b/drivers/input/keyboard/tegra-kbc.c
@@ -376,7 +376,7 @@ static int tegra_kbc_start(struct tegra_kbc *kbc)
 	/* Reset the KBC controller to clear all previous status.*/
 	reset_control_assert(kbc->rst);
 	udelay(100);
-	reset_control_assert(kbc->rst);
+	reset_control_deassert(kbc->rst);
 	udelay(100);
 
 	tegra_kbc_config_pins(kbc);
-- 
1.9.1
-- 
Dmitry
Thread (4 messages) 4 messages, 4 authors, last reply 2016-08-22
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help