Thread (4 messages) 4 messages, 3 authors, 2016-08-02

Re: [PATCH] input/hid: Add a new Saitek mouse device ID (RAT 9)

flat view

From: Jiri Kosina <jikos@kernel.org>
Date: 2016-08-02 15:25:36
Also in: lkml

On Mon, 1 Aug 2016, Benjamin Tissoires wrote:
quoted
 static int hid_uevent(struct device *dev, struct kobj_uevent_env *env)
 {
-	struct hid_device *hdev = to_hid_device(dev);	
+	struct hid_device *hdev = to_hid_device(dev);
Usually, if the change is not related to the patch, it needs to be in
its own patch. The rational being that if we need to revert the patch,
the cleanups won't.
Yeah, let's fix this once someone is actually touching the code in 
question.

I've removed this hunk, and applied the rest of the patch to 
for-4.8/upstream-fixes. Thanks,

-- 
Jiri Kosina
SUSE Labs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help