Re: [PATCH] input/mouse/elantech.c: Remove trackpoint related label

On Mon, Jul 25, 2016 at 11:33:32AM -0700, Dmitry Torokhov wrote:

On Mon, Jul 25, 2016 at 10:34:28AM +0000, Marcos Souza wrote:

quoted

Hi,

On Mon, Jul 25, 2016 at 6:54 AM Benjamin Tissoires <
benjamin.tissoires@redhat.com> wrote:

quoted

Hi,

On Jul 23 2016 or thereabouts, Marcos Paulo de Souza wrote:

quoted

by rearranging the code to release the trackpoint resource when some

error

quoted

happens.

Is there any advantage of doing so beside trying to remove one goto?
Because if not, that's the kernel failure style and this is much better
given that if somebody needs to add other commands after initializing the
trackstick, and if those command fail, we can then remove the
trackstick.

My only reason was to shrink the code a little, by removing a label used

Shrink executable code or source code? I do not see either of them
shrinking, you have the same number of code lines and compiler is going
to rearrange the instructions the way it sees fit anyway.

By the way, it looks like you are taking the addresses from
git_maitainer.pl but the output is "interesting" to say the least. You
have

"open list:INPUT (KEYBOARD, MOUSE, JOYSTICK, TOUCHSCREEN),
linux-kernel@vger.kernel.org (open list)" [off-list ref]

as one of the recipients while.

Thanks.

-- 
Dmitry