Re: [PATCH] Input: wacom_w8001 - drop use of ABS_MT_TOOL_TYPE

On Thu, Jul 14, 2016 at 03:57:59PM +1000, Peter Hutterer wrote:

On Wed, Jul 13, 2016 at 05:22:30PM -0700, Ping Cheng wrote:

quoted

On Wednesday, July 13, 2016, Dmitry Torokhov [off-list ref] wrote:

quoted

On Mon, Jan 11, 2016 at 12:12 AM, Dmitry Torokhov
[off-list ref] wrote:

quoted

On Mon, Jan 11, 2016 at 01:51:51PM +1000, Peter Hutterer wrote:

quoted

As of e0361b70175f0cd6199dd9ed6679632de73973d4
  Input: wacom_w8001 - split the touch and pen devices into two devices
the touch events aren't multiplexed over the same device anymore, the use of
ABS_MT_TOOL_TYPE is superfluous. And even before then it only ever sent
MT_TOOL_TYPE_FINGER anyway.

Signed-off-by: Peter Hutterer <redacted>

Applied, thank you.

Hmm, so I applied that but removal of input_mt_report_slot_state()
means that we do not generate tacking IDs for the contacts.

You are right. I have a set of patches to clean up the code. It is
still under testing/reviewing...

quoted

Revert?

It may be quicker to revert this one now. I'll submit the clean up set later.

yeah, I agree and we found another bug with these devices. It'll be easier
to merge the fixed set.

OK, reverted (and revert marked for stable). I added your acks to the
revert commit.

Thanks!

-- 
Dmitry