Re: [PATCH v4 2/2] input: add ADC resistor ladder driver

On Fri, Jul 29, 2016 at 12:49:21AM +0200, Alexandre Belloni wrote:

On 28/07/2016 at 15:09:18 -0700, Dmitry Torokhov wrote :

quoted

On Tue, Jul 12, 2016 at 05:41:50PM -0700, Dmitry Torokhov wrote:

quoted

Hi Alexandre,

On Tue, Jul 12, 2016 at 09:36:26PM +0200, Alexandre Belloni wrote:

quoted

A common way of multiplexing buttons on a single input in cheap devices is
to use a resistor ladder on an ADC. This driver supports that configuration
by polling an ADC channel provided by IIO.

This looks quite reasonable, just a few small comments.

Ping.

Did the version below work for you? I am trying sweep in the brand new
drivers before we close merge window.

I was thinking it was too late for 4.8. I've juste tested and it works

Nah, it is OK - the dirver is brand-new so we can't possibly regress
anyone ;)

fine. However, I just sent v5 including the exact same changes but
changing mvolt to millivolt as that seemed preferred by Rob. Both
versions haver been tested and are fine for me.

Let's see if he acks the binding then...

Thanks.

-- 
Dmitry