Re: [RFC v0 4/8] Input: goodix: use firmware_stat instead of completion
From: Bastien Nocera <hadess@hadess.net>
Date: 2016-07-28 12:21:05
Also in:
linux-wireless, lkml
On Thu, 2016-07-28 at 13:59 +0200, Daniel Wagner wrote:
On 07/28/2016 01:22 PM, Bastien Nocera wrote:quoted
On Thu, 2016-07-28 at 09:55 +0200, Daniel Wagner wrote:quoted
From: Daniel Wagner <redacted> Loading firmware is an operation many drivers implement in various ways around the completion API. And most of them do it almost in the same way. Let's reuse the firmware_stat API which is used also by the firmware_class loader. Apart of streamlining the firmware loading states we also document it slightly better. Signed-off-by: Daniel Wagner <redacted>Irina added and tested that feature, so best for her to comment on this, as I don't have any hardware that would use this feature.In case you have any comments on the API, let me know. I'll add Irina to the Cc list in the next version.
Looking at the API, I really don't like the mixing of namespaces. Either it's fw_ or it's firmware_ but not a mix of both. Also looks like fw_loading_start() would do nothing as the struct is likely zero initialised, and FW_STATUS_LOADING == 0. Maybe you need an UNSET enum member? FW_STATUS_ABORT <- FW_STATUS_ABORTED, to match the adjective suffixes of the other members. Ditto fw_loading_abort() which doesn't abort firmware loading but sets the status. Cheers