Re: [PATCH 1/2] input: adc-keys: add DT binding documentation
From: Jonathan Cameron <jic23@kernel.org>
Date: 2016-07-03 13:44:01
Also in:
linux-devicetree, linux-iio, lkml
On 01/07/16 22:30, Alexandre Belloni wrote:
Add documentation for ADC keys Signed-off-by: Alexandre Belloni <redacted>
Clean looking binding to me - one comment inline. Jonathan
quoted hunk ↗ jump to hunk
--- Cc: Rob Herring <robh+dt@kernel.org> Cc: devicetree@vger.kernel.org .../devicetree/bindings/input/adc-keys.txt | 45 ++++++++++++++++++++++ 1 file changed, 45 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/adc-keys.txtdiff --git a/Documentation/devicetree/bindings/input/adc-keys.txt b/Documentation/devicetree/bindings/input/adc-keys.txt new file mode 100644 index 000000000000..873476bb4eab --- /dev/null +++ b/Documentation/devicetree/bindings/input/adc-keys.txt@@ -0,0 +1,45 @@ +Allwinner sun4i low res adc attached tablet keys
What is allwinner specific in here? Looks pretty general purpose to me!
+------------------------------------------------
+
+Required properties:
+ - compatible: "adc-keys"
+ - io-channels: Phandle to an ADC channel
+ - io-channel-names = "buttons";
+ - voltage-keyup-mvolt: Voltage at which all the keys are considered up.
+
+Each key is represented as a sub-node of "adc-keys":
+
+Required subnode-properties:
+ - label: Descriptive name of the key.
+ - linux,code: Keycode to emit.
+ - voltage-mvolt: Voltage adc input when this key is pressed.
+
+Example:
+
+#include <dt-bindings/input/input.h>
+
+ adc-keys {
+ compatible = "adc-keys";
+ io-channels = <&lradc 0>;
+ io-channel-names = "buttons";
+ voltage-keyup-mvolt = <2000>;
+
+ button@1500 {
+ label = "Volume Up";
+ linux,code = <KEY_VOLUMEUP>;
+ voltage-mvolt = <1500>;
+ };
+
+ button@1000 {
+ label = "Volume Down";
+ linux,code = <KEY_VOLUMEDOWN>;
+ voltage-mvolt = <1000>;
+ };
+
+ button@500 {
+ label = "Enter";
+ linux,code = <KEY_ENTER>;
+ voltage-mvolt = <500>;
+ };
+ };
+