Thread (13 messages) 13 messages, 3 authors, 2016-06-16

Re: [PATCH v2 4/5] mfd: tps65217: Add power button as subdevice

From: Marcin Niestroj <hidden>
Date: 2016-06-16 11:43:51
Also in: linux-devicetree, linux-omap, linux-pm

On 16.06.2016 12:36, Lee Jones wrote:
On Wed, 15 Jun 2016, Marcin Niestroj wrote:
quoted
Hi,

On 15.06.2016 16:12, Lee Jones wrote:
quoted
On Tue, 14 Jun 2016, Marcin Niestroj wrote:
quoted
Add tps65217 power buttor subdevice with assigned IRQ resources.

Signed-off-by: Marcin Niestroj <redacted>
---
depends on patch 1 in series

drivers/mfd/tps65217.c | 10 ++++++++++
1 file changed, 10 insertions(+)
Applied, thanks.
Did you also apply patch 1? As I stated above, this patch depends on
patch 1.
Nope.  It looks like you still have changes to make.

What does it rely on?  The IRQ define?
Yes, TPS65217_IRQ_PB is an enum declared in patch 1.

I have just send new version of the whole patch series including your
suggestions.
quoted
quoted
quoted
diff --git a/drivers/mfd/tps65217.c b/drivers/mfd/tps65217.c
index d49f94e..68cf431 100644
--- a/drivers/mfd/tps65217.c
+++ b/drivers/mfd/tps65217.c
@@ -38,6 +38,10 @@ static struct resource charger_resources[] = {
	DEFINE_RES_IRQ_NAMED(TPS65217_IRQ_USB, "USB"),
};

+static struct resource pb_resources[] = {
+	DEFINE_RES_IRQ_NAMED(TPS65217_IRQ_PB, "PB"),
+};
+
struct tps65217_irq {
	int mask;
	int interrupt;
@@ -122,6 +126,12 @@ static struct mfd_cell tps65217s[] = {
		.resources = charger_resources,
		.of_compatible = "ti,tps65217-charger",
	},
+	{
+		.name = "tps65217-pwrbutton",
+		.num_resources = ARRAY_SIZE(pb_resources),
+		.resources = pb_resources,
+		.of_compatible = "ti,tps65217-pwrbutton",
+	},
};

static irqreturn_t tps65217_irq_thread(int irq, void *data)
-- 
Marcin Niestroj
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help