Re: [PATCH v5 9/9] Input: sur40 - use new V4L2 touch input type
From: Florian Echtler <hidden>
Date: 2016-06-23 06:41:55
Also in:
linux-media, lkml
On 23.06.2016 00:08, Nick Dyer wrote:
quoted hunk ↗ jump to hunk
diff --git a/drivers/input/touchscreen/sur40.c b/drivers/input/touchscreen/sur40.c index 880c40b..841e045 100644 --- a/drivers/input/touchscreen/sur40.c +++ b/drivers/input/touchscreen/sur40.c@@ -599,7 +599,7 @@ static int sur40_probe(struct usb_interface *interface, sur40->vdev.queue = &sur40->queue; video_set_drvdata(&sur40->vdev, sur40); - error = video_register_device(&sur40->vdev, VFL_TYPE_GRABBER, -1); + error = video_register_device(&sur40->vdev, VFL_TYPE_TOUCH, -1); if (error) { dev_err(&interface->dev, "Unable to register video subdevice.");
As far as I could tell from looking at patch 1/9, the only visible change for userspace will be the device name, so I'd be fine with this.
quoted hunk ↗ jump to hunk
@@ -794,7 +794,7 @@ static int sur40_vidioc_enum_fmt(struct file *file, void *priv, if (f->index != 0) return -EINVAL; strlcpy(f->description, "8-bit greyscale", sizeof(f->description)); - f->pixelformat = V4L2_PIX_FMT_GREY; + f->pixelformat = V4L2_TCH_FMT_TU08;
I would suggest to leave the pixel format as it is. Rationale: the data really is greyscale image intensity data (as also evidenced by [1]), not just a synthetic image, and changing the pixel format would break all userspace tools. [1] https://github.com/mkalten/reacTIVision/issues/3#issuecomment-99931807 Best, Florian -- SENT FROM MY DEC VT50 TERMINAL
Attachments
- signature.asc [application/pgp-signature] 198 bytes