Re: [PATCH 2/6] hid: intel_ish-hid: ISH Transport layer

On Fri, 17 Jun 2016, Jiri Kosina wrote:

quoted

+struct ishtp_cl_device *ishtp_bus_add_device(struct ishtp_device *dev,
+					     uuid_le uuid, char *name)
+{

Should be static.

Actually, going deeper into the code and trying to untangle all the 
dependencies, there are quite a few more in other ipc.c, hid-client.c, 
etc. Please fix that globally in the next iteration.

Thanks,

-- 
Jiri Kosina
SUSE Labs