Re: [PATCH 2/6] hid: intel_ish-hid: ISH Transport layer

From
Jiri Kosina <jikos@kernel.org>
Date
2016-06-17 20:45:35
Also in
linux-iio, lkml
Reply to
Jiri Kosina, 2016-06-17
On Fri, 17 Jun 2016, Jiri Kosina wrote:
quoted
+struct ishtp_cl_device *ishtp_bus_add_device(struct ishtp_device *dev,
+					     uuid_le uuid, char *name)
+{
Should be static.
Actually, going deeper into the code and trying to untangle all the 
dependencies, there are quite a few more in other ipc.c, hid-client.c, 
etc. Please fix that globally in the next iteration.

Thanks,

-- 
Jiri Kosina
SUSE Labs
Thread (16 messages) 16 messages, 5 authors, last reply 2016-06-20
Keyboard shortcuts
hback out one level
jnext message in thread / next series-diff position
kprevious message in thread / previous series-diff position
ldrill in
Escclose help / fold thread tree
?toggle this help