Re: [PATCH] hid-elo: kill not flush the work
From: Benjamin Tissoires <hidden>
Date: 2016-05-31 15:39:19
Also in:
stable
On Tue, May 31, 2016 at 2:48 PM, Oliver Neukum [off-list ref] wrote:
Flushing a work that reschedules itself is not a sensible operation. It needs to be killed. Failure to do so leads to a kernel panic in the timer code. Signed-off-by: Oliver Neukum <ONeukum@suse.com> CC: stable@vger.kernel.org
Good catch. Reviewed-by: Benjamin Tissoires <redacted> Thanks! Benjamin
quoted hunk ↗ jump to hunk
--- drivers/hid/hid-elo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)diff --git a/drivers/hid/hid-elo.c b/drivers/hid/hid-elo.c index aad8c16..0cd4f72 100644 --- a/drivers/hid/hid-elo.c +++ b/drivers/hid/hid-elo.c@@ -261,7 +261,7 @@ static void elo_remove(struct hid_device *hdev) struct elo_priv *priv = hid_get_drvdata(hdev); hid_hw_stop(hdev); - flush_workqueue(wq); + cancel_delayed_work_sync(&priv->work); kfree(priv); } --2.1.4 -- To unsubscribe from this list: send the line "unsubscribe linux-input" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html