Thread (7 messages) 7 messages, 3 authors, 2016-05-13

Re: [PATCH 1/3] Input - soc_button_array: use gpio_is_valid()

flat view

From: Fabio Estevam <festevam@gmail.com>
Date: 2016-05-10 15:56:21
Also in: lkml

On Tue, May 10, 2016 at 12:37 PM, Benjamin Tissoires
[off-list ref] wrote:
quoted hunk ↗ jump to hunk
@@ -92,7 +93,7 @@ soc_button_device_create(struct platform_device *pdev,
                        continue;

                gpio = soc_button_lookup_gpio(&pdev->dev, info->acpi_index);
-               if (gpio < 0)
+               if (gpio_is_valid(gpio))
Shouldn't it be "if (!gpio_is_valid(gpio))" ?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help