Re: [PATCH] Input: byd: don't wipe dynamically allocated memory twice
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2016-04-26 16:50:50
On Thu, Apr 21, 2016 at 10:58:17PM +0300, Vladimir Zapolskiy wrote:
Since memory for a private data is allocated by kzalloc() there is no need to fill it with zeroes immediately after the allocation. Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
Applied, thank you.
quoted hunk ↗ jump to hunk
--- drivers/input/mouse/byd.c | 1 - 1 file changed, 1 deletion(-)diff --git a/drivers/input/mouse/byd.c b/drivers/input/mouse/byd.c index fdc243c..ec73f75 100644 --- a/drivers/input/mouse/byd.c +++ b/drivers/input/mouse/byd.c@@ -473,9 +473,8 @@ int byd_init(struct psmouse *psmouse) priv = kzalloc(sizeof(*priv), GFP_KERNEL); if (!priv) return -ENOMEM; - memset(priv, 0, sizeof(*priv)); setup_timer(&priv->timer, byd_clear_touch, (unsigned long) psmouse); psmouse->private = priv; psmouse->disconnect = byd_disconnect;-- 2.1.4
-- Dmitry