Re: [PATCH] Input: i8042 - Fix console keyboard support on Gen2 Hyper-V VMs
From: Mark Laws <hidden>
Date: 2016-04-19 10:46:11
From: Mark Laws <hidden>
Date: 2016-04-19 10:46:11
On Tue, Apr 19, 2016 at 5:22 PM, Dan Carpenter [off-list ref] wrote:
Yeah. Just remove the call to i8042_controller_check(). Wouldn't everyone be happy with that situation?
No problem, I agree this is better--just wasn't sure what you meant initially.
Your patch makes life slightly more complicated for people who want to use the original hardware if the load the module but the hardware isn't detected.
That is true, but apparently nobody can think of a better solution (including me :)) and this bug has been open for two years. Having to rmmod in the corner case where the module gets loaded but no i8042 is present seems a small price to pay for having the keyboard work regardless of CONFIG_I8042=y or m. Right now, any distribution with CONFIG_I8042=m has a non-functional keyboard on Hyper-V Gen2 VMs, which is probably frustrating for (e.g.) Arch Linux users who find themselves unable to type and thus can't install their distribution. Regards, Mark Laws -- |v\ /\ |\ |< |_ /\ \^| //