Re: [PATCH v8 2/7] Input: cros_ec_keyb - Stop handling interrupts directly

On 26 April 2016 at 08:57, Lee Jones [off-list ref] wrote:

On Tue, 26 Apr 2016, Tomeu Vizoso wrote:

quoted

On 25 April 2016 at 23:17, Dmitry Torokhov [off-list ref] wrote:

quoted

On Tue, Apr 12, 2016 at 02:32:25PM +0200, Tomeu Vizoso wrote:

quoted

From: Vic Yang <redacted>

Because events other that keyboard ones will be handled by now on by
other drivers, stop directly handling interrupts and instead listen to
the new notifier in the MFD driver.

Hmm, where did Vic's sign-off go?

Lee Jones asked to remove them in a previous version as he considers
them superfluous. My understanding is that as I'm the first to submit
them to mainline, the chain starts with me (I certify the b section of
http://developercertificate.org/).

Hmm... It seems what I said has been misconstrued a little.  You
*should* remove SoBs from people who were *only* part of the
submission path.  However, you should *not* remove SoBs from patch
*authors*.  Since Vic is the author (or at least one of them), their
SoB should remain.

Apologies if that was not clear.

I see now, will fix the tags in the next revision.

Thanks,

Tomeu