Re: [PATCH v4 1/4] Input: cyttsp - use devres managed resource allocations
From: Dmitry Torokhov <hidden>
Date: 2016-01-21 19:29:32
Also in:
linux-devicetree, lkml
Hi Oreste, On Thu, Jan 21, 2016 at 08:21:13PM +0100, Oreste Salerno wrote:
Use devm_() functions for allocating memory, input device and IRQ.
...
quoted hunk ↗ jump to hunk
@@ -625,11 +620,8 @@ EXPORT_SYMBOL_GPL(cyttsp_probe); void cyttsp_remove(struct cyttsp *ts) { - free_irq(ts->irq, ts); - input_unregister_device(ts->input); if (ts->pdata->exit) ts->pdata->exit(); - kfree(ts);
This is not quite correct as it changes the operations order... Given that it is going to be removed in the next patch I guess it is OK, but ideally you can add a custom devm action to shut off the chip. Thanks. -- Dmitry -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html