Thread (7 messages) 7 messages, 2 authors, 2015-12-11

Re: [PATCH v2] Input: atmel_mxt_ts - Add maxtouch to I2C table for module autoload

From: Javier Martinez Canillas <hidden>
Date: 2015-12-10 23:07:55
Also in: lkml

Hello Dmitry,

On 11/20/2015 04:15 PM, Dmitry Torokhov wrote:
On Fri, Nov 20, 2015 at 04:09:42PM -0300, Javier Martinez Canillas wrote:
quoted
The Atmel maxtouch DT binding documents that the compatible string for
the device is "atmel,maxtouch" and the I2C core always reports a module
alias of the form i2c:alias where alias is the compatible string model:

$ grep MODALIAS /sys/devices/platform/12e00000.i2c/i2c-8/8-004b/uevent
MODALIAS=i2c:maxtouch
Do we know why we are not reporting modalias as "of:..." so that
autoloading using the of table works properly?

It sounds like the of matching and modalias is quite a mess at the
moment.
I already explained the issues with OF modalias and why I believe
$SUBJECT is the least bad solution for now until the I2C subsystem
is changed to properly report OF modalias.

Please let me know if you are considering applying this or if
module autoloading will be broken for this driver in the meantime.
 
Thanks.
Best regards,
-- 
Javier Martinez Canillas
Open Source Group
Samsung Research America
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help