Thread (3 messages) flat view 3 messages, 2 authors, 2015-11-16

Re: drivers/hid/wacom_wac.c:2484: bad if test ?

From: Jiri Kosina <jikos@kernel.org>
Date: 2015-11-16 22:39:11

On Mon, 16 Nov 2015, David Binderman wrote:
Hello there,

drivers/hid/wacom_wac.c:2484:35: warning: logical ‘or’ of collectively 
exhaustive tests is always true [-Wlogical-op]

Source code is

if (features->type>= INTUOSHT || features->type <= BAMBOO_PT)
Good catch, that code is obviously crappy.

Adding Ping, Aaron and Jason to CC.

-- 
Jiri Kosina
SUSE Labs

--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help