Re: [PATCH] hid: usbhid: hid-core: fix recursive deadlock

On Thu, 19 Nov 2015, Ioan-Adrian Ratiu wrote:

But please understand further my reasoning for submitting this patch. 
Consider if this is a bug in the wacom driver or in the usbhid core? IMO 
this is a usbhid bug: the critical region in hid_ctrl() is too big, 
there is no reason for the call to hid_input_report() to be protected by 
usbhid->lock.

Hmm, it's actually true that we might not need usbhid->lock during 
hid_input_report() at the end of the day, as we shouldn't be doing any 
URB-related operations there, neither iofl are being manipulated.

If you have already done the full analysis that shows that usbhid->lock is 
indeed not needed, this absolutely needs to go into changelog as proper 
justification.

Could you please reformulate the changelog in this respect and resubmit?

Thanks,

-- 
Jiri Kosina
SUSE Labs