On 6 May 2015 at 20:36, Dmitry Torokhov [off-list ref] wrote:

On Tue, Apr 21, 2015 at 04:36:44PM +0200, Michael Hennerich wrote:

quoted

On 04/21/2015 04:21 PM, Guido Martínez wrote:

quoted

The event mask was specified as 0xF (4 bits) when in reality is 0x1F (5
bits) in order to be capable of representing all FIFO length values from
0 to 16.

This caused a problem: when the keypad reported 16 pending events the
driver took it as 0, and did nothing. This in turn caused the keypad to
re-issue the interrupt over and over again.

Fixes: 9d2e173644bb ('Input: ADP5589 - new driver for I2C Keypad Decoder and I/O Expander')
Signed-off-by: Guido Martínez <redacted>

Acked-by: Michael Hennerich <michael.hennerich@analog.com>

Dmitry,

Going through this patchset and noticed the "Fixes" tag got dropped when
the last two fixes were pushed.

More importantly, the patches haven't been queued for -stable, despite it
fixes a serious issue.

Can you take care of sending them to -stable or should I do it?
Upstream commits are:
c615dcb6d13e Input: adp5589-keys - fix event count mask
195e610bf710 Input: adp5589-keys - fix pull mask setting

Thanks!
-- 
Ezequiel García, VanguardiaSur
www.vanguardiasur.com.ar
--
To unsubscribe from this list: send the line "unsubscribe linux-input" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html