Re: [PATCH] input:gpio-key: set IRQF_NO_SUSPEND for wake capable key

On Fri, Oct 02, 2015 at 03:26:27AM -0700, Linus Walleij wrote:

On Thu, Sep 17, 2015 at 9:06 AM, Qipeng Zha [off-list ref] wrote:

quoted

When wakeup attribute is set, GPIO key is supposed to wake up
the system from system sleep state, So set IRQF_NO_SUSPEND
flag to keep IRQ enabled during suspend.

Signed-off-by: Qi Zheng <redacted>
Signed-off-by: Aubrey Li <redacted>
Signed-off-by: Qipeng Zha <qipeng.zha@intel.com>

Reviewed-by: Linus Walleij <redacted>

Should this not be tagged for stable?

I do not believe we need this at all. Otherwise every single driver for
devices that might be wakeup sources needs this flag set. Which would
basically means it is a noop and we should not suspend IRQ threads by
default.

The dirver correctly calls enable_irq_wake() and platform should do
whatever it needs to make sure wakeup interrupt will be serviced.

Thanks.

-- 
Dmitry