Re: [PATCH] xen: check return value of xenbus_printf
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Date: 2015-10-19 16:46:56
Also in:
lkml
On Mon, Oct 19, 2015 at 04:02:51PM +0000, Insu Yun wrote:
Signed-off-by: Insu Yun <redacted>
Applied, thank you. However you still are missing the commit description on this version of the patch; I had to fish it from your original posting. Thanks.
quoted hunk ↗ jump to hunk
--- drivers/input/misc/xen-kbdfront.c | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)diff --git a/drivers/input/misc/xen-kbdfront.c b/drivers/input/misc/xen-kbdfront.c index 23d0549..0a9ad2cf 100644 --- a/drivers/input/misc/xen-kbdfront.c +++ b/drivers/input/misc/xen-kbdfront.c@@ -129,8 +129,14 @@ static int xenkbd_probe(struct xenbus_device *dev, if (xenbus_scanf(XBT_NIL, dev->otherend, "feature-abs-pointer", "%d", &abs) < 0) abs = 0; - if (abs) - xenbus_printf(XBT_NIL, dev->nodename, "request-abs-pointer", "1"); + if (abs) { + ret = xenbus_printf(XBT_NIL, dev->nodename, + "request-abs-pointer", "1"); + if (ret) { + pr_warning("xenkbd: can't request abs-pointer"); + abs = 0; + } + } /* keyboard */ kbd = input_allocate_device();-- 1.9.1
-- Dmitry