On Fri 02 Oct 10:47 PDT 2015, Dmitry Torokhov wrote:

On Mon, Jul 27, 2015 at 06:50:18PM -0700, Bjorn Andersson wrote:

quoted

As gpio_keys_setup_key() only operates on the device, pass a pointer to
this from the probe instead of a platform_device and make the usage
consistent. Also make probe() more consistent by dropping the local copy
of the device pointer.

Signed-off-by: Bjorn Andersson <redacted>

Don't really see the difference either way... We trade &pdev->dev for
dev in one place and trade dev for &pdev->dev in another. I'd rather
skip it.

Thanks.

No worries, my dislike of the mixing of the two uses within the first
function was enough to hack up a patch - feel free to drop it as you
don't think it's worth the churn.


Thanks for merging the error handling patch though.

Regards,
Bjorn