Thread (5 messages) 5 messages, 2 authors, 2015-09-11

Re: [PATCH 1/2] Input: at32psif: handle clk_enable return value

flat view

From: Fabio Estevam <festevam@gmail.com>
Date: 2015-09-11 03:10:34

On Fri, Sep 11, 2015 at 12:02 AM, WEN Pingbo [off-list ref] wrote:
quoted hunk ↗ jump to hunk
-       clk_enable(psif->pclk);
+       retval = clk_enable(psif->pclk);
+       if (retval < 0)
+               dev_err(&psif->pdev->dev,
+                       "could not enable pclk, ret %d\n", retval);
Shouldn't you add a 'return' here to prevent the code to proceed with
the failed clock?
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help