Thread (3 messages) read the whole thread 3 messages, 2 authors, 2015-08-28

Re: [PATCH 1/2] HID: wacom: Set button bits based on a new numbered_buttons

From: Jiri Kosina <jikos@kernel.org>
Date: 2015-08-28 18:45:22

On Thu, 20 Aug 2015, Aaron Skomra wrote:
quoted hunk ↗ jump to hunk
Prior to this commit, numbered button bit setting was done separately
for each device type in wacom_setup_pad_capabilities(). Here we add a
numbered_buttons property to the wacom_features struct and extract the
repeated bit setting code to a new function:
wacom_settup_numbered_buttons().

Signed-off-by: Aaron Skomra <redacted>
Reviewed-by: Jason Gerecke <jason.gerecke@wacom.com>
---
 drivers/hid/wacom_wac.c | 175 +++++++++++++++++-------------------------------
 drivers/hid/wacom_wac.h |   1 +
 2 files changed, 61 insertions(+), 115 deletions(-)
diff --git a/drivers/hid/wacom_wac.c b/drivers/hid/wacom_wac.c
index baba9a0..a19aeae 100644
--- a/drivers/hid/wacom_wac.c
+++ b/drivers/hid/wacom_wac.c
@@ -2513,11 +2513,23 @@ int wacom_setup_touch_input_capabilities(struct input_dev *input_dev,
 	return 0;
 }
 
+void wacom_setup_numbered_buttons(struct input_dev *input_dev,
I made this static, and applied both patches. Thanks,

-- 
Jiri Kosina
SUSE Labs
Keyboard shortcuts
hback out one level
jnext message in thread
kprevious message in thread
ldrill in
Escclose help / fold thread tree
?toggle this help